Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floats and images within are misplaced on Wikipedia #2422

Open
pcwalton opened this issue May 13, 2014 · 3 comments
Open

Floats and images within are misplaced on Wikipedia #2422

pcwalton opened this issue May 13, 2014 · 3 comments

Comments

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented May 13, 2014

Test case: http://en.wikipedia.org/wiki/Coyote

The images and floats are in the wrong place.

@pcwalton pcwalton changed the title Floats and images within are misaligned on Wikipedia Floats and images within are misplaced on Wikipedia May 13, 2014
@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented May 13, 2014

@june0cho Do you or any of your team have interested in working on this, given your familiarity with layout?

@june0cho
Copy link
Contributor

@june0cho june0cho commented May 24, 2014

@larsbergstrom Sorry for late reply. I missed your comment.
I'll try to look into this.

@june0cho
Copy link
Contributor

@june0cho june0cho commented Jun 4, 2014

For the image, vertical-align: middle seems wrong. It is similar in the following case as well:

First line <p>
<div style="border:solid red 1px">
  In div tag <img src="../src/test/html/rust-0.png" style="vertical-align:middle"/>
</div>
bors-servo pushed a commit that referenced this issue Jun 5, 2014
It fixes the wrong vertical alignment for img element. (related to #2422, #2554)
Worked with @ryanc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.