Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement convertToBlob API for OffscreenCanvas #24272

Open
jdm opened this issue Sep 24, 2019 · 3 comments
Open

Implement convertToBlob API for OffscreenCanvas #24272

jdm opened this issue Sep 24, 2019 · 3 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Sep 24, 2019

WebIDL: https://html.spec.whatwg.org/multipage/canvas.html#the-offscreencanvas-interface
Spec: https://html.spec.whatwg.org/multipage/canvas.html#dom-offscreencanvas-converttoblob
Code:

  • components/script/dom/webidls/OffscreenCanvas.webidl
  • components/script/dom/offscreencanvas.rs

Tests: ./mach test-wpt tests/wpt/web-platform-tests/offscreen-canvas/convert-to-blob/

@gterzian
Copy link
Member

@gterzian gterzian commented Sep 24, 2019

This might be best done after #24123, since that PR implies some fairly significant changes to Blob(a bunch of reshuffling really).

@gterzian
Copy link
Member

@gterzian gterzian commented Sep 24, 2019

Also, we might want to first implement Transferable for OffscreenCanvas, since that might imply some reshuffling in the implementation of OffscreenCanvas(I assume something similar as the split between MessagePort and MessagePortImpl being done in #23637), and such as change could signifanctly affect the implementation of convertToBlob. See #24276

@jdm
Copy link
Member Author

@jdm jdm commented Sep 25, 2019

I doubt that those will have a significant impact on the implementation here - this task is focused on getting the pixels from the canvas and stashing them in a blob, so the implementation details of either the canvas or blob shouldn't really affect it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.