Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GL video textures as webgl textures #24349

Open
jdm opened this issue Oct 2, 2019 · 2 comments
Open

Support GL video textures as webgl textures #24349

jdm opened this issue Oct 2, 2019 · 2 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Oct 2, 2019

#24233 added support for getting pixel data from a video frame and using that as a webgl texture, but creates an empty frame when we're using GL textures instead of raw pixels.

Yes, I think adding a new code path where we send a texture ID to the WebGL thread and use something like glBlitFramebuffer or glCopySubTexImage2D to copy the texture data to the destination texture will make the most sense.

@ferjm ferjm added this to To do in WebGL content Oct 3, 2019
@ferjm ferjm added this to To do in Media playback Oct 3, 2019
@ferjm ferjm self-assigned this Oct 22, 2019
@ferjm ferjm moved this from To do to In progress in Media playback Nov 21, 2019
@jdm
Copy link
Member Author

@jdm jdm commented Dec 13, 2019

master...ferjm:webgl.video.gl is the WIP branch.

@ceyusa
Copy link
Collaborator

@ceyusa ceyusa commented Dec 17, 2019

Not sure where to comment about this. I'll just bring a comment I put in the branch:

I have just tested the old implementation (x11/raw frames) and it doesn't work anymore. Perhaps the surfman change produced a regression?

And I can't enable WebGL in Linux/Wayland now with surfman (i knew how to enable it in the old offscreen-rendering-context, but not anymore :/).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
WebGL content
  
To do
Media playback
  
In progress
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.