Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image cache needs to be keyed on more attributes #24368

Closed
jdm opened this issue Oct 4, 2019 · 0 comments
Closed

Image cache needs to be keyed on more attributes #24368

jdm opened this issue Oct 4, 2019 · 0 comments
Labels
A-content/images

Comments

@jdm
Copy link
Member

@jdm jdm commented Oct 4, 2019

According to https://html.spec.whatwg.org/multipage/images.html#list-of-available-images we need to consider:

  • the URL
  • the source element's CORS attribute
  • an origin (optionally)
@jdm jdm added the A-content/images label Oct 4, 2019
@jdm jdm mentioned this issue Oct 4, 2019
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Oct 4, 2019
@bors-servo
Auto merge of #24340 - jdm:image-cache-cors, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
19af1cf 
Allow using CORS filtered image responses as WebGL textures

More specifically, this makes the "is this image same origin?" check consider the CORS status of the original response, rather than relying on an overly-strict "is this image's response's URL same-origin with a particular global?" check. To do this, we make the image cache double keyed based on the requested URL as well as the requesting origin, and store the CORS status of the eventual response with the final image that eventually gets sent to the HTMLImageElement consumer.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24330 and fix #24368
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24340)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Oct 7, 2019
@bors-servo
Auto merge of #24340 - jdm:image-cache-cors, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b90c28c 
Allow using CORS filtered image responses as WebGL textures

More specifically, this makes the "is this image same origin?" check consider the CORS status of the original response, rather than relying on an overly-strict "is this image's response's URL same-origin with a particular global?" check. To do this, we make the image cache double keyed based on the requested URL as well as the requesting origin, and store the CORS status of the eventual response with the final image that eventually gets sent to the HTMLImageElement consumer.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24330 and fix #24368
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24340)
<!-- Reviewable:end -->
@bors-servo bors-servo closed this in 75548f4 Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/images
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Allow using CORS filtered image responses as WebGL textures
1 participant
@jdm
You can’t perform that action at this time.