Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getInputSources API isn't spec-compliant #24395

Closed
jdm opened this issue Oct 8, 2019 · 3 comments
Closed

getInputSources API isn't spec-compliant #24395

jdm opened this issue Oct 8, 2019 · 3 comments
Assignees
@Manishearth
Labels
A-xr-spec-complete A-xr-zomg

Comments

@jdm
Copy link
Member

@jdm jdm commented Oct 8, 2019

The WebXR spec calls for XRSession to have a inputSources attribute that returns a FrozenArray. We have a getInputSources method that returns a sequence instead, because of #10072. I think the best way to deal with this is make our attribute return an any WebIDL value, store a cached JSVal that is a frozen JS array.
@jdm
Copy link
Member Author

@jdm jdm commented Oct 8, 2019

This breaks various three.js demos.
@Manishearth Manishearth self-assigned this Oct 8, 2019
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Oct 8, 2019

It's not a FrozenArray, that was the change we made in the spec, it's an iterable. We support this I think.
@jdm
Copy link
Member Author

@jdm jdm commented Oct 8, 2019

Indeed!
@Manishearth Manishearth mentioned this issue Oct 8, 2019
Merged
bors-servo added a commit that referenced this issue Oct 8, 2019
@bors-servo
Auto merge of #24397 - Manishearth:inputarray, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
91032d6 
Support new way of doing input source arrays

Fixes #24395

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24397)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Oct 8, 2019
@bors-servo
Auto merge of #24397 - Manishearth:inputarray, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a753f12 
Support new way of doing input source arrays

Fixes #24395

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24397)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Oct 8, 2019
@bors-servo
Auto merge of #24397 - Manishearth:inputarray, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f19c1fb 
Support new way of doing input source arrays

Fixes #24395

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24397)
<!-- Reviewable:end -->
@bors-servo bors-servo closed this in ec408e9 Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manishearth Manishearth

Labels
A-xr-spec-complete A-xr-zomg
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Support new way of doing input source arrays
2 participants
@jdm @Manishearth
You can’t perform that action at this time.