Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<a target=XXX> creates a new top level browsing context, which is not supported by embedders #24400

Open
atouchet opened this issue Oct 9, 2019 · 7 comments

Comments

@atouchet
Copy link
Contributor

@atouchet atouchet commented Oct 9, 2019

Steps to reproduce:

  1. Press Ctrl + L and enter https://servo.org/bhtml-newtab/newtab.html
  2. Click on the DuckDuckGo tile to navigate to https://duckduckgo.com/html/
  3. Press Ctrl + L and enter https://servo.org/bhtml-newtab/newtab.html again. This time https://servo.org/bhtml-newtab/newtab.html does not load and the page remains on https://duckduckgo.com/html/. The window's title bar does change to the correct page however.

Tested in Windows 10.

@atouchet atouchet changed the title Navigating to a new page Issues with navigating to a new page Oct 9, 2019
@atouchet
Copy link
Contributor Author

@atouchet atouchet commented Oct 9, 2019

This issue also occurs when attempting to load a new page instead of reloading https://servo.org/bhtml-newtab/newtab.html.

@naokiri
Copy link

@naokiri naokiri commented Nov 1, 2019

Reproduced on current master (65bcf63), Ubuntu Linux 18.04.

@jdm
Copy link
Member

@jdm jdm commented Nov 1, 2019

Also reproduced on macOS. Very curious...

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Nov 6, 2019

Ran into this today.

The issue is with target attribute. Simpler STR:

Create a file "a.html" containing: <a target="foo" href="http://example.com">CLICK</a>:

./mach run -d file:///tmp/a.html
click on "CLICK"
Ctrl-L
type: about:blank
@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Nov 6, 2019

The glutin port doesn't support tabs yet. We should at least print an error: #24672

See:

/// id of the top level browsing context. It is unique as tabs

and:

// TODO: properly handle a new "tab"

paulrouget added a commit to paulrouget/servo.org that referenced this issue Nov 14, 2019
It's not properly supported by Servo's port yet.
See servo/servo#24400
paulrouget added a commit to paulrouget/servo.org that referenced this issue Nov 14, 2019
It's not properly supported by Servo's port yet.
See servo/servo#24400
jdm added a commit to servo/servo.org that referenced this issue Nov 14, 2019
It's not properly supported by Servo's port yet.
See servo/servo#24400
@atouchet
Copy link
Contributor Author

@atouchet atouchet commented May 20, 2020

I am no longer able to reproduce the original issue which I assume is due to servo/servo.org#81. Should this be closed then or would it be better to repurpose the issue?

@jdm
Copy link
Member

@jdm jdm commented May 21, 2020

It would be better to repurpose the issue and include a minimal set of html files that demonstrate the issue when navigating between them.

@paulrouget paulrouget changed the title Issues with navigating to a new page <a target=XXX> creates a new top level browsing context, which is not supported by embedders May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.