Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate why we get XR STOPPING events when opening the menu for some demos #24437

Closed
paulrouget opened this issue Oct 14, 2019 · 9 comments
Closed

Investigate why we get XR STOPPING events when opening the menu for some demos #24437

paulrouget opened this issue Oct 14, 2019 · 9 comments
Labels
P-hololens

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Oct 14, 2019 •
edited

With http://paulrouget.com/test/webxr-ar.html, as soon as the start menu appears.
With http://paulrouget.com/test/bbjs/basic/ , the 2nd time the menu appears, followed by a full reload

Looking at it now.
@paulrouget paulrouget mentioned this issue Oct 14, 2019
Closed
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Oct 15, 2019

Now it's crashing in CoreUIComponents followed by the "finding your space" UI to pop up in a loop. Likely an openxr/hl issue.
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Oct 15, 2019

I can not reproduce with MS-provided OpenXR apps. Trying to put together a test case.
@paulrouget

This comment was marked as off-topic.

Sign in to view
@paulrouget paulrouget closed this Oct 17, 2019
@paulrouget

This comment was marked as off-topic.

Sign in to view
@paulrouget paulrouget reopened this Oct 17, 2019
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Oct 22, 2019

Logs don't help much. Doubled checked that xrRequestExitSession is not called on our side.

26.2633056,.WinXrContinuousProvider,6216:5052,11606,WaitFrame,0,0,5,Step:"NextFrameReady",
26.2640352,.WinXrContinuousProvider,6216:5052,11462,WaitFrame_Result,0,0,4,ShouldRender:true, TimeToPhotonMs:174.18975830078125,
26.2640480,.WinXrContinuousProvider,6216:5052,6374,xrLocateViews,0,0,5,Session:2, Space:4, ViewCapacity:0, ViewConfig:2,
26.2640560,.WinXrContinuousProvider,6216:5052,6458,xrLocateViews_Result,0,0,5,Result:"XR_SUCCESS", ViewCountOutput:2, ViewStateFlags:140731574416273,
26.2640848,.WinXrContinuousProvider,6216:5052,6374,xrLocateViews,0,0,5,Session:2, Space:4, ViewCapacity:2, ViewConfig:2,
26.2644816,.WinXrContinuousProvider,6216:5052,6458,xrLocateViews_Result,0,0,5,Result:"XR_SUCCESS", ViewCountOutput:2, ViewStateFlags:15,
26.2646048,.WinXrContinuousProvider,6216:5052,5434,xrSyncActions,0,0,5,ActionSetCount:1, Session:2,
26.2646400,.WinXrContinuousProvider,6216:5052,5390,xrSyncActions_Result,0,0,5,Result:"XR_SUCCESS",
26.2646512,.WinXrProvider,6216:5052,7105,xrCreateActionSpace,0,0,4,Action:8, Session:2,
26.2646720,.WinXrProvider,6216:5052,7056,xrCreateActionSpace_Result,0,0,4,Space:302,
26.2646784,.WinXrContinuousProvider,6216:5052,7481,xrLocateSpace,0,0,5,Space:302, Time:2224219184700,
26.2646880,.WinXrContinuousProvider,6216:5052,7395,xrLocateSpace_Result,0,0,5,locationFlags:0, velocityFlags:0, velocityRequested:false,
26.2646944,.WinXrProvider,6216:5052,7019,xrDestroySpace,0,0,4,Space:302,
26.2647088,.WinXrProvider,6216:5052,7105,xrCreateActionSpace,0,0,4,Action:9, Session:2,
26.2647168,.WinXrProvider,6216:5052,7056,xrCreateActionSpace_Result,0,0,4,Space:303,
26.2647200,.WinXrContinuousProvider,6216:5052,7481,xrLocateSpace,0,0,5,Space:303, Time:2224219184700,
26.2647216,.WinXrContinuousProvider,6216:5052,7395,xrLocateSpace_Result,0,0,5,locationFlags:0, velocityFlags:0, velocityRequested:false,
26.2647248,.WinXrProvider,6216:5052,7019,xrDestroySpace,0,0,4,Space:303,
26.2647312,.WinXrContinuousProvider,6216:5052,4911,xrGetActionStateBoolean,0,0,5,Action:10, Session:2, SubactionPath:0,
26.2647488,.WinXrContinuousProvider,6216:5052,4982,xrGetActionStateBoolean_Result,0,0,5,ChangedSinceLastSync:false, CurrentState:false, IsActive:false, 
26.2647552,.WinXrProvider,6216:5052,7105,xrCreateActionSpace,0,0,4,Action:11, Session:2,
26.2647616,.WinXrProvider,6216:5052,7056,xrCreateActionSpace_Result,0,0,4,Space:304,
26.2647632,.WinXrContinuousProvider,6216:5052,7481,xrLocateSpace,0,0,5,Space:304, Time:2224219184700,
26.2647664,.WinXrContinuousProvider,6216:5052,7395,xrLocateSpace_Result,0,0,5,locationFlags:0, velocityFlags:0, velocityRequested:false,
26.2647680,.WinXrProvider,6216:5052,7019,xrDestroySpace,0,0,4,Space:304,
26.2647728,.WinXrProvider,6216:5052,7105,xrCreateActionSpace,0,0,4,Action:12, Session:2,
26.2647792,.WinXrProvider,6216:5052,7056,xrCreateActionSpace_Result,0,0,4,Space:305,
26.2647808,.WinXrContinuousProvider,6216:5052,7481,xrLocateSpace,0,0,5,Space:305, Time:2224219184700,
26.2647840,.WinXrContinuousProvider,6216:5052,7395,xrLocateSpace_Result,0,0,5,locationFlags:0, velocityFlags:0, velocityRequested:false,
26.2647856,.WinXrProvider,6216:5052,7019,xrDestroySpace,0,0,4,Space:305,
26.2647888,.WinXrContinuousProvider,6216:5052,4911,xrGetActionStateBoolean,0,0,5,Action:13, Session:2, SubactionPath:0,
26.2647936,.WinXrContinuousProvider,6216:5052,4982,xrGetActionStateBoolean_Result,0,0,5,ChangedSinceLastSync:false, CurrentState:false, IsActive:false, 
26.2797296,.WinXrProvider,6216:6164,12607,FrameworkView_OnVisibilityChanged,0,0,4,Visible:false,
26.2797360,.WinXrProvider,6216:6164,23710,SessionStateManager_SetSessionFocused,0,0,4,focused:false,
26.2797440,.WinXrProvider,6216:6164,23272,SessionStateManager_Transition,0,0,4,RequestedStates:29, To:"XR_SESSION_STATE_VISIBLE",
26.2797488,.WinXrProvider,6216:6164,31005,EventEnqueue,0,0,4,Type:"XR_TYPE_EVENT_DATA_SESSION_STATE_CHANGED",
26.2797552,.WinXrProvider,6216:6164,23345,SessionStateManager_SendSessionStateChangedEvent,0,0,4,SessionState:"XR_SESSION_STATE_VISIBLE",
26.2797584,.WinXrProvider,6216:6164,24041,SessionStateManager_SetSessionVisible,0,0,4,visible:false,
26.2797600,.WinXrProvider,6216:6164,23272,SessionStateManager_Transition,0,0,4,RequestedStates:13, To:"XR_SESSION_STATE_SYNCHRONIZED",
26.2797632,.WinXrProvider,6216:6164,31005,EventEnqueue,0,0,4,Type:"XR_TYPE_EVENT_DATA_SESSION_STATE_CHANGED",
26.2797664,.WinXrProvider,6216:6164,23345,SessionStateManager_SendSessionStateChangedEvent,0,0,4,SessionState:"XR_SESSION_STATE_SYNCHRONIZED",
26.2797696,.WinXrProvider,6216:6164,23656,SessionStateManager_SetSessionStopping,0,0,4,
26.2797712,.WinXrProvider,6216:6164,23272,SessionStateManager_Transition,0,0,4,RequestedStates:77, To:"XR_SESSION_STATE_STOPPING",
26.2797728,.WinXrProvider,6216:6164,31005,EventEnqueue,0,0,4,Type:"XR_TYPE_EVENT_DATA_SESSION_STATE_CHANGED",
26.2797760,.WinXrProvider,6216:6164,23345,SessionStateManager_SendSessionStateChangedEvent,0,0,4,SessionState:"XR_SESSION_STATE_STOPPING",
26.2797776,.WinXrProvider,6216:6164,24104,SessionStateManager_ResetStoppingRequest,0,0,4,RequestedStates:13,
26.2798288,.WinXrContinuousProvider,6216:6164,16070,BaseHolographicWindow_HandleUserPresenceChanged,0,0,4,userPresence:0,
26.2858096,.WinXrContinuousProvider,6216:6272,17,DllMain,0,0,5,Reason:"ThreadAttach", 
26.5524752,.WinXrContinuousProvider,6216:5052,6673,xrBeginFrame,0,0,4,Session:2,
26.5525008,.WinXrContinuousProvider,6216:5052,6630,xrBeginFrame_Result,0,0,5,Result:"XR_SUCCESS",
26.5525088,.WinXrContinuousProvider,6216:5052,7922,xrAcquireSwapchainImage,0,0,5,Swapchain:5,
26.5525168,.WinXrContinuousProvider,6216:5052,7864,xrAcquireSwapchainImage_Result,0,0,5,ImageIndex:0, 
26.5525232,.WinXrContinuousProvider,6216:5052,7765,xrWaitSwapchainImage,0,0,5,Swapchain:5, Timeout:9223372036854775807,
26.5525264,.WinXrContinuousProvider,6216:5052,7821,xrWaitSwapchainImage_Result,0,0,5,
26.5525312,.WinXrContinuousProvider,6216:5052,7922,xrAcquireSwapchainImage,0,0,5,Swapchain:6,
26.5525360,.WinXrContinuousProvider,6216:5052,7864,xrAcquireSwapchainImage_Result,0,0,5,ImageIndex:0, 
26.5525392,.WinXrContinuousProvider,6216:5052,7765,xrWaitSwapchainImage,0,0,5,Swapchain:6, Timeout:9223372036854775807,
26.5525424,.WinXrContinuousProvider,6216:5052,7821,xrWaitSwapchainImage_Result,0,0,5,
26.5525472,.WinXrContinuousProvider,6216:5052,8033,xrEnumerateSwapchainImages,0,0,5,Swapchain:5,
26.5525520,.WinXrContinuousProvider,6216:5052,7972,xrEnumerateSwapchainImages_Result,0,0,5,OutputSize:3, 
26.5525888,.WinXrContinuousProvider,6216:5052,8033,xrEnumerateSwapchainImages,0,0,5,Swapchain:5,
26.5525936,.WinXrContinuousProvider,6216:5052,7972,xrEnumerateSwapchainImages_Result,0,0,5,OutputSize:3, 
26.5526352,.WinXrContinuousProvider,6216:5052,8033,xrEnumerateSwapchainImages,0,0,5,Swapchain:6,
26.5526384,.WinXrContinuousProvider,6216:5052,7972,xrEnumerateSwapchainImages_Result,0,0,5,OutputSize:3, 
26.5526432,.WinXrContinuousProvider,6216:5052,8033,xrEnumerateSwapchainImages,0,0,5,Swapchain:6,
26.5526496,.WinXrContinuousProvider,6216:5052,7972,xrEnumerateSwapchainImages_Result,0,0,5,OutputSize:3, 
26.5528208,.WinXrContinuousProvider,6216:5052,7664,xrReleaseSwapchainImage,0,0,5,Swapchain:5,
26.5528288,.WinXrContinuousProvider,6216:5052,7664,xrReleaseSwapchainImage,0,0,5,Swapchain:6,
26.5528464,.WinXrContinuousProvider,6216:5052,6570,xrEndFrame,0,0,4,Session:2,
26.5529696,.WinXrContinuousProvider,6216:5052,26809,GetAndLockAvailableSwapchainImage,0,0,5,Swapchain:5,
26.5529760,.WinXrContinuousProvider,6216:5052,26809,GetAndLockAvailableSwapchainImage,0,0,5,Swapchain:6,
26.5553056,.WinXrContinuousProvider,6216:5052,26876,ReleaseAvailableSwapchainImage,0,0,5,Swapchain:5,
26.5553152,.WinXrContinuousProvider,6216:5052,26876,ReleaseAvailableSwapchainImage,0,0,5,Swapchain:6,
26.5553312,.WinXrContinuousProvider,6216:5052,6535,xrEndFrame_Complete,0,0,5,
26.5807648,.WinXrContinuousProvider,6216:5052,921,xrPollEvent,0,0,5,Instance:1, 
26.5807968,.WinXrProvider,6216:5052,881,xrPollEvent_Result,0,0,4,Type:"XR_TYPE_EVENT_DATA_SESSION_STATE_CHANGED",
26.5808128,.WinXrContinuousProvider,6216:5052,921,xrPollEvent,0,0,5,Instance:1, 
26.5808192,.WinXrProvider,6216:5052,881,xrPollEvent_Result,0,0,4,Type:"XR_TYPE_EVENT_DATA_SESSION_STATE_CHANGED",
26.5808240,.WinXrContinuousProvider,6216:5052,921,xrPollEvent,0,0,5,Instance:1, 
26.5808288,.WinXrProvider,6216:5052,881,xrPollEvent_Result,0,0,4,Type:"XR_TYPE_EVENT_DATA_SESSION_STATE_CHANGED",
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Oct 22, 2019

@Manishearth according to the team thread:

"STOPPING" doesn't mean "EXIT" in hololens

so what are we supposed to do on Stop, and when are we supposed to call session.end?
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Oct 22, 2019

We should do nothing on STOPPING, and we should be sending a visibility change event on IDLE
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Oct 22, 2019

I'm planning on making these changes, though an easy fix is to just remove STOPPING from the match
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Nov 11, 2019

FIxed in servo/webxr#78
@paulrouget paulrouget closed this Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-hololens
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@paulrouget @Manishearth
You can’t perform that action at this time.