Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIgnore document.open/write after active parser has been aborted #24458
Comments
bors-servo
added a commit
that referenced
this issue
Jan 1, 2020
Attempt at #24458 [draft] Let's see how this does in tests. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
How do I mark a WPT test as non-intermittent? I think I've made a change that takes some test cases from intermittent fail to definite pass. |
bors-servo
added a commit
that referenced
this issue
Jan 2, 2020
Add "active parser was aborted boolean" to Document Aborting the document now definitely prevents a subsequent document.open from working, per spec as seen in #24458. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes fix #24458 and fix #21279 <!-- Either: --> - [X] There are tests for these changes (currently intermittent in #21279, this will make them deterministically pass) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this issue
Jan 3, 2020
Add "active parser was aborted boolean" to Document Aborting the document now definitely prevents a subsequent document.open from working, per spec as seen in #24458. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes fix #24458 and fix #21279 <!-- Either: --> - [X] There are tests for these changes (currently intermittent in #21279, this will make them deterministically pass) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
whatwg/html#4907