Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIntermittent failure in /fetch/security/embedded-credentials.tentative.sub.html #24488
Labels
Comments
Member
jdm
commented
Oct 18, 2019
Merged
|
Removing label because it looks like this would be fixed by #25771 |
bors-servo
added a commit
that referenced
this issue
Feb 15, 2020
Leak message ports in Dom, until they are closed <!-- Please describe your changes on the following line: --> FIX #25461 FIX #24810 FIX #24488 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
It would be better to add a "Fixes #24488" and leave the label until then. |
bors-servo
added a commit
that referenced
this issue
Feb 21, 2020
Leak message ports in Dom, until they are closed <!-- Please describe your changes on the following line: --> FIX #25461 FIX #24810 FIX #24488 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment