Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babylon color picker demo requires two clicks to choose a colour #24530

Closed
jdm opened this issue Oct 23, 2019 · 1 comment
Closed

Babylon color picker demo requires two clicks to choose a colour #24530

jdm opened this issue Oct 23, 2019 · 1 comment
Labels

Comments

@jdm
Copy link
Member

@jdm jdm commented Oct 23, 2019

In http://paulrouget.com/test/bbjs/basic/ when I run it in Firefox I can choose a colour with one click. In Servo it requires two clicks each time.

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Oct 28, 2019

The issue was coming from a workaround I put in place to avoid #24363 - this is now fixed in the demo.

@paulrouget paulrouget closed this Oct 28, 2019
bors-servo added a commit that referenced this issue Oct 31, 2019
UWP: More mouse events

Support more UWP Desktop events (mouse wheel, mouse move, etc).

This introduces a new issue, where the basic bbjs demo requires double click to select a color (unrelated to #24530 I believe). Filed #24596.

Next step is to properly fire touch events in HoloLens and only mouse events on Desktop (see #24587).
bors-servo added a commit that referenced this issue Nov 1, 2019
UWP: More mouse events

Support more UWP Desktop events (mouse wheel, mouse move, etc).

This introduces a new issue, where the basic bbjs demo requires double click to select a color (unrelated to #24530 I believe). Filed #24596.

Next step is to properly fire touch events in HoloLens and only mouse events on Desktop (see #24587).
bors-servo added a commit that referenced this issue Nov 1, 2019
UWP: More mouse events

Support more UWP Desktop events (mouse wheel, mouse move, etc).

This introduces a new issue, where the basic bbjs demo requires double click to select a color (unrelated to #24530 I believe). Filed #24596.

Next step is to properly fire touch events in HoloLens and only mouse events on Desktop (see #24587).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.