Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CanvasState::IsPointInPath should return false for Nan/infinite values #24540

Closed
jdm opened this issue Oct 24, 2019 · 2 comments
Closed

CanvasState::IsPointInPath should return false for Nan/infinite values #24540

jdm opened this issue Oct 24, 2019 · 2 comments
Labels
A-content/canvas C-assigned

Comments

@jdm
Copy link
Member

@jdm jdm commented Oct 24, 2019

Spec: https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-ispointinpath
Implementation: components/script/dom/canvasrenderingocontext2d.rs
Tests: ./mach test-wpt /2dcontext/path-objects/2d.path.isPointInPath.nonfinite.html
@jdm jdm mentioned this issue Oct 24, 2019
Merged
3 of 4 tasks complete
@teapotd
Copy link
Contributor

@teapotd teapotd commented Oct 28, 2019

@highfive assign me
@highfive highfive added the C-assigned label Oct 28, 2019
@highfive
Copy link

@highfive highfive commented Oct 28, 2019

Hey @teapotd! Thanks for your interest in working on this issue. It's now assigned to you!
@teapotd teapotd mentioned this issue Oct 28, 2019
Merged
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/canvas C-assigned
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Return false from CanvasState::is_point_in_path for NaN/infinite values
3 participants
@jdm @teapotd @highfive
You can’t perform that action at this time.