Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please release selectors crate #24574

Closed
federicomenaquintero opened this issue Oct 28, 2019 · 10 comments
Closed

Please release selectors crate #24574

federicomenaquintero opened this issue Oct 28, 2019 · 10 comments

Comments

@federicomenaquintero
Copy link
Contributor

@federicomenaquintero federicomenaquintero commented Oct 28, 2019

Could we please have a new release of the selectors crate? I could really use the fix for #22972 in librsvg 😃

@jdm
Copy link
Member

@jdm jdm commented Oct 28, 2019

Paging @emilio. I forget whether mozilla-central or servo is considered the source of truth these days.

@emilio
Copy link
Member

@emilio emilio commented Oct 29, 2019

Shouldn't really matter, both should be almost in sync, if not fully in sync.

But I could do a sync and then report back.

@mashedcode
Copy link

@mashedcode mashedcode commented Nov 2, 2019

Could we please have a new release of the selectors crate so that we can use/avoid clashes with the new cssparser version?

@atouchet
Copy link
Contributor

@atouchet atouchet commented Dec 18, 2019

selectors has been updated in Servo: #25330

This just needs to be published to crates.io now.

@emilio
Copy link
Member

@emilio emilio commented Dec 19, 2019

Ah, there's another gotcha.

$ cargo publish                                                                                                                                                                                                                            
    Updating crates.io index
error: all dependencies must have a version specified when publishing.
dependency `to_shmem` does not specify a version
Note: The published dependency will use the version from crates.io,
the `path` specification will be removed from the dependency declaration.

I'll release a version with the servo_arc / to_shmem bits stripped off, and tag it somewhere on the repo.

@emilio
Copy link
Member

@emilio emilio commented Dec 19, 2019

Published v.0.22.0: https://github.com/emilio/servo/releases/tag/selectors-v0.22.0

@jdm / @SimonSapin I no longer have the right to push tags to the repo it seems, mind pushing that for me (or restoring my push access I guess? I think I used to have it)

Sorry this took so long :(

@emilio emilio closed this Dec 19, 2019
@jdm
Copy link
Member

@jdm jdm commented Dec 19, 2019

You should now have the access that allows pushing tags.

@atouchet
Copy link
Contributor

@atouchet atouchet commented Dec 19, 2019

@federicomenaquintero
Copy link
Contributor Author

@federicomenaquintero federicomenaquintero commented Dec 27, 2019

Thank you!!! This is now being used in librsvg master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.