Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babylonjs demo crashes since Angle update #24578

Closed
paulrouget opened this issue Oct 29, 2019 · 1 comment
Closed

babylonjs demo crashes since Angle update #24578

paulrouget opened this issue Oct 29, 2019 · 1 comment
Assignees
@jdm
Labels
A-content/webgl I-panic
Projects
UWP port

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Oct 29, 2019

I should have tested with the babylonjs demos as well:

thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
  left: `1286`,
 right: `0`: Unexpected WebGL error: 0x506 (1286)', components\canvas\webgl_thread.rs:1713:9

/cc @jdm
@jdm jdm self-assigned this Oct 29, 2019
@jdm jdm added this to To do in UWP port via automation Oct 29, 2019
@jdm
Copy link
Member

@jdm jdm commented Oct 29, 2019

This occurs because the new ANGLE does not like when a framebuffer's color attachment is a texture initialized with GL_RGBA and GL_FLOAT. I'm going to investigate how Firefox treats this, as well as why the old ANGLE allowed it.
@jdm jdm mentioned this issue Oct 29, 2019
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Oct 29, 2019
@bors-servo
Auto merge of #24583 - jdm:angle-bbjs-fix, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
466733a 
Fix GL panic with updated ANGLE

Our OES_texture_float extension implementation relied on the GL implementation to convert from unsized formats like RGBA when using the FLOAT/HALF_FLOAT type to an internal sized format that was acceptable. ANGLE no longer appears to do that since #24542, so we should enable the format conversion unconditionally.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24578
- [x] There are tests for these changes
UWP port automation moved this from To do to Done Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdm jdm

Labels
A-content/webgl I-panic
Projects
UWP port
  
Done
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fix GL panic with updated ANGLE
2 participants
@jdm @paulrouget
You can’t perform that action at this time.