Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate finger taps into mouse events or touch events (hololens) #24587

Closed
paulrouget opened this issue Oct 30, 2019 · 1 comment
Closed

Translate finger taps into mouse events or touch events (hololens) #24587

paulrouget opened this issue Oct 30, 2019 · 1 comment

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Oct 30, 2019

For now we only catch mouse events, making page interaction impossible in HoloLens mode.

Just removing the PointerDeviceType == Mouse test appears to work.
@paulrouget paulrouget mentioned this issue Oct 31, 2019
Merged
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Oct 31, 2019

Dupe of #24598
@paulrouget paulrouget closed this Oct 31, 2019
bors-servo added a commit that referenced this issue Oct 31, 2019
@bors-servo
Auto merge of #24597 - paulrouget:mouse, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ac568d9 
UWP: More mouse events

Support more UWP Desktop events (mouse wheel, mouse move, etc).

This introduces a new issue, where the basic bbjs demo requires double click to select a color (unrelated to #24530 I believe). Filed #24596.

Next step is to properly fire touch events in HoloLens and only mouse events on Desktop (see #24587).
bors-servo added a commit that referenced this issue Nov 1, 2019
@bors-servo
Auto merge of #24597 - paulrouget:mouse, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6d9449b 
UWP: More mouse events

Support more UWP Desktop events (mouse wheel, mouse move, etc).

This introduces a new issue, where the basic bbjs demo requires double click to select a color (unrelated to #24530 I believe). Filed #24596.

Next step is to properly fire touch events in HoloLens and only mouse events on Desktop (see #24587).
bors-servo added a commit that referenced this issue Nov 1, 2019
@bors-servo
Auto merge of #24597 - paulrouget:mouse, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
48d918d 
UWP: More mouse events

Support more UWP Desktop events (mouse wheel, mouse move, etc).

This introduces a new issue, where the basic bbjs demo requires double click to select a color (unrelated to #24530 I believe). Filed #24596.

Next step is to properly fire touch events in HoloLens and only mouse events on Desktop (see #24587).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@paulrouget
You can’t perform that action at this time.