Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFailing to parse a URL in the UWP app causes a panic #24589
Closed
Labels
Projects
Comments
|
I can't reproduce. An invalid URL should load duckduckgo or show an error message. |
|
Hmm. I know that a panic was caught in servo/ports/libsimpleservo/capi/src/lib.rs Lines 434 to 439 in d671010 https://mrdoob.neocities.org/018/https://mrdoob.neocities.org/019/, but I didn't see the actual URL that I tried to load.
|
|
Right. It's better if this would not panic. But I don't see how we could end up with a non-valid URL there. I'll investigate, and at least handle invalid URL better. |
bors-servo
added a commit
that referenced
this issue
Nov 6, 2019
Do not assume UWP and Servo agree on URL validity This should address #24589. Note: to check that a URL is valid, we try to parse the url and if an exception is raised, we assume the url is not valid. Even though we catch the exception, Visual Studio might "force" the crash + break here: https://github.com/servo/servo/compare/master...paulrouget:url?expand=1#diff-4e059561062fe024a35522f60f7f14c1R116 - I'm not sure why. In VS, in the Exception Setting, we need to uncheck the Break When Thrown option to avoid that crash. It only happens for few urls and I'm unclear why. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24589 (GitHub issue number if applicable) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Try to load an invalid URL in the UWP app and watch it panic. We should pop up an alert dialog or something, but it should really be ignored rather than bring down the browser.