Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upbbjs basic demo: double click required if mouse move triggered #24596
Labels
Comments
bors-servo
added a commit
that referenced
this issue
Oct 31, 2019
UWP: More mouse events Support more UWP Desktop events (mouse wheel, mouse move, etc). This introduces a new issue, where the basic bbjs demo requires double click to select a color (unrelated to #24530 I believe). Filed #24596. Next step is to properly fire touch events in HoloLens and only mouse events on Desktop (see #24587).
bors-servo
added a commit
that referenced
this issue
Nov 1, 2019
UWP: More mouse events Support more UWP Desktop events (mouse wheel, mouse move, etc). This introduces a new issue, where the basic bbjs demo requires double click to select a color (unrelated to #24530 I believe). Filed #24596. Next step is to properly fire touch events in HoloLens and only mouse events on Desktop (see #24587).
bors-servo
added a commit
that referenced
this issue
Nov 1, 2019
UWP: More mouse events Support more UWP Desktop events (mouse wheel, mouse move, etc). This introduces a new issue, where the basic bbjs demo requires double click to select a color (unrelated to #24530 I believe). Filed #24596. Next step is to properly fire touch events in HoloLens and only mouse events on Desktop (see #24587).
This was referenced Nov 11, 2019
bors-servo
added a commit
that referenced
this issue
Nov 11, 2019
Properly set event.buttons value on mousemove A regular mousemove doesn't have any pressed button. And we were not resetting the pressed buttons after a click. That was messing up some jquery polyfil. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24596 (GitHub issue number if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When mouse move events are fired, the color picker requires 2 clicks to be activated.