Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGL resize sends a Result but never sends an Err value #24602

Open
jdm opened this issue Oct 31, 2019 · 0 comments
Open

WebGL resize sends a Result but never sends an Err value #24602

jdm opened this issue Oct 31, 2019 · 0 comments
Labels
A-content/webgl I-cleanup

Comments

@jdm
Copy link
Member

@jdm jdm commented Oct 31, 2019 •
edited

In #24482 resize_webgl_context is modified to panic when any underlying errors occur during resizing. This makes the Result value redundant, and we could just have a Sender<()> instead. Additionally, we should experiment and see if we can make the resize operation non-synchronous and remove the sender entirely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/webgl I-cleanup
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@jdm
You can’t perform that action at this time.