Windows build fails to create graphics context

[saschanaz]

> ./mach run
**********************************************************************
** Visual Studio 2019 Developer Command Prompt v16.3.2
** Copyright (c) 2019 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x64'
Failed to create graphics context!: NoCurrentContext (thread main, at src\libcore\result.rs:1165)
stack backtrace:
   0: backtrace::backtrace::trace_unsynchronized<closure-0>
             at C:\Users\sasch\.cargo\registry\src\github.com-1ecc6299db9ec823\backtrace-0.3.38\src\backtrace\mod.rs:66
   1: backtrace::backtrace::trace<closure-0>
             at C:\Users\sasch\.cargo\registry\src\github.com-1ecc6299db9ec823\backtrace-0.3.38\src\backtrace\mod.rs:53
   2: backtrace::capture::Backtrace::create
             at C:\Users\sasch\.cargo\registry\src\github.com-1ecc6299db9ec823\backtrace-0.3.38\src\capture.rs:164
   3: backtrace::capture::Backtrace::new
             at C:\Users\sasch\.cargo\registry\src\github.com-1ecc6299db9ec823\backtrace-0.3.38\src\capture.rs:128
   4: servo::main::{{closure}}
             at ports\glutin\main2.rs:142
   5: std::panicking::rust_panic_with_hook
             at /rustc/246be7e1a557b8ac8287c6842379a0db67770be6\/src\libstd\panicking.rs:472
   6: std::panicking::continue_panic_fmt
             at /rustc/246be7e1a557b8ac8287c6842379a0db67770be6\/src\libstd\panicking.rs:375
   7: std::panicking::rust_begin_panic
             at /rustc/246be7e1a557b8ac8287c6842379a0db67770be6\/src\libstd\panicking.rs:302
   8: core::panicking::panic_fmt
             at /rustc/246be7e1a557b8ac8287c6842379a0db67770be6\/src\libcore\panicking.rs:84
   9: core::result::unwrap_failed
             at /rustc/246be7e1a557b8ac8287c6842379a0db67770be6\/src\libcore\result.rs:1165
  10: core::result::Result<(surfman::platform::windows::angle::device::Device, surfman::platform::windows::angle::context::Context), surfman::error::Error>::expect<(surfman::platform::windows::angle::device::Device, surfman::platform::windows::angle::context::C
             at /rustc/246be7e1a557b8ac8287c6842379a0db67770be6\src\libcore\result.rs:960
  11: servo::create_webgl_threads<WindowPortsMethods>
             at components\servo\lib.rs:1038
  12: servo::Servo<WindowPortsMethods>::new<WindowPortsMethods>
             at components\servo\lib.rs:464
  13: servo::app::App::run
             at ports\glutin\app.rs:73
  14: servo::main
             at ports\glutin\main2.rs:170
  15: std::rt::lang_start::{{closure}}<()>
             at /rustc/246be7e1a557b8ac8287c6842379a0db67770be6\src\libstd\rt.rs:61
  16: std::panicking::try::do_call<closure-0,i32>
             at /rustc/246be7e1a557b8ac8287c6842379a0db67770be6\/src\libstd\panicking.rs:287
  17: panic_unwind::__rust_maybe_catch_panic
             at /rustc/246be7e1a557b8ac8287c6842379a0db67770be6\/src\libpanic_unwind\lib.rs:80
  18: std::rt::lang_start_internal
             at /rustc/246be7e1a557b8ac8287c6842379a0db67770be6\/src\libstd\rt.rs:47
  19: std::rt::lang_start<()>
             at /rustc/246be7e1a557b8ac8287c6842379a0db67770be6\src\libstd\rt.rs:61
  20: main
  21: __scrt_common_main_seh
             at d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
  22: BaseThreadInitThunk
  23: RtlUserThreadStart

Servo exited with return value 101

The window opens and shortly after that it crashes. Both the local and nightly build show the same error.

[jdm]

Does it run if you use mach run --angle?

[saschanaz]

It does.

[jdm]

This code uses the default surfman device, which is the ANGLE device. When --angle is not specified, we should be using the wgl device from surfman instead.

[asajeffrey]

OK, we have a problem here, because we use the universal device throughout servo and webxr, which for windows is always the angle device. Fixing this to allow non-angle windows would probably require rewriting the code to be generic in the device, which is something we should do at some point, but is non-trivial. For the moment we could just make --angle the default?

[rasviitanen]

I also have this issue. mach run --angle works for me. However, I can not run mach test-wpt test/path -- --angle. Is there any fix to this, so I can run my tests before this is resolved?

[jdm]

mach test-wpt --binary-arg=--angle test/path should do the trick.

[fwcd]

I am having a similar issue, running the nightly build from https://download.servo.org on Windows 10:

Failed to create graphics context!: NoCurrentContext (thread main, at src\libcore\result.rs:1187)
stack backtrace:
   0: HeapFree
   1: JS::RealmBehaviors::discardSource
   2: JS::ubi::Concrete<JSScript>::coarseType
   3: JSAutoNullableRealm::operator=
   4: JSAutoNullableRealm::operator=
   5: JSAutoNullableRealm::operator=
   6: JSTracer::asCallbackTracer
   7: JSTracer::asCallbackTracer
   8: JS::AutoRequireNoGC::~AutoRequireNoGC
   9: JS::AutoRequireNoGC::~AutoRequireNoGC
  10: JS::ubi::Concrete<JSScript>::coarseType
  11: JS::AutoRequireNoGC::~AutoRequireNoGC
  12: JSAutoNullableRealm::operator=
  13: JSTracer::asCallbackTracer
  14: JSAutoNullableRealm::operator=
  15: JS::ubi::Concrete<JSScript>::coarseType
  16: MozFormatCodeAddress
  17: BaseThreadInitThunk
  18: RtlUserThreadStart

The application crashes immediately after startup.

[jdm]

You should be able to work around that by starting it from a terminal window and passing --angle.

[atouchet]

For the moment we could just make --angle the default?

This would be nice to have. The current situation with Servo crashing at launch by default is not great.