Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uwp: cancel_current_task() throws at shutdown #24635

Closed
paulrouget opened this issue Nov 4, 2019 · 1 comment
Closed

uwp: cancel_current_task() throws at shutdown #24635

paulrouget opened this issue Nov 4, 2019 · 1 comment
Assignees
@paulrouget
Labels
P-hololens

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Nov 4, 2019

Looks like a recent regression.
@paulrouget paulrouget changed the title cancel_current_task() throws at shutdown uwp: cancel_current_task() throws at shutdown Nov 4, 2019
@paulrouget paulrouget self-assigned this Nov 4, 2019
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Nov 4, 2019

cancel_current_task() does not need to be called because we are shutting down, I'm assuming the runtime is cancelling all the task at that point anyway. We just need to let the thread finish, and everything shuts down as expected.

This is interesting though. When VS is debugging, by default, it's not breaking on all the exceptions. Breaking on all exceptions show some errors we did not see in the past (including this one). I'll file an issue to list all exceptions raised in that "strict" mode.
@paulrouget paulrouget mentioned this issue Nov 4, 2019
Merged
bors-servo added a commit that referenced this issue Nov 6, 2019
@bors-servo
Auto merge of #24646 - paulrouget:nocancel, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
20894a3 
No need to cancel the task. The thread is ending.

Fix #24635
bors-servo added a commit that referenced this issue Nov 6, 2019
@bors-servo
Auto merge of #24646 - paulrouget:nocancel, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e34b8f2 
No need to cancel the task. The thread is ending.

Fix #24635
bors-servo added a commit that referenced this issue Nov 6, 2019
@bors-servo
Auto merge of #24646 - paulrouget:nocancel, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
17619e2 
No need to cancel the task. The thread is ending.

Fix #24635
bors-servo added a commit that referenced this issue Nov 6, 2019
@bors-servo
Auto merge of #24646 - paulrouget:nocancel, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0a80fab 
No need to cancel the task. The thread is ending.

Fix #24635
bors-servo added a commit that referenced this issue Nov 6, 2019
@bors-servo
Auto merge of #24646 - paulrouget:nocancel, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
efb1d58 
No need to cancel the task. The thread is ending.

Fix #24635
bors-servo added a commit that referenced this issue Nov 6, 2019
@bors-servo
Auto merge of #24646 - paulrouget:nocancel, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b21cf18 
No need to cancel the task. The thread is ending.

Fix #24635
@bors-servo bors-servo closed this in 64560ec Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulrouget paulrouget

Labels
P-hololens
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

No need to cancel the task. The thread is ending.
1 participant
@paulrouget
You can’t perform that action at this time.