Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it so test-tidy with clang-format run on the CI #24637

Closed
paulrouget opened this issue Nov 4, 2019 · 4 comments
Closed

Make it so test-tidy with clang-format run on the CI #24637

paulrouget opened this issue Nov 4, 2019 · 4 comments
Assignees
Labels

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Nov 4, 2019

If I understand correctly, test-tidy only run on Linux. We need to figure out how to run the same clang-format version on both linux and windows, so we can activate CPP formatting tests on the CI.

@paulrouget paulrouget self-assigned this Nov 4, 2019
@paulrouget paulrouget added the A-testing label Nov 4, 2019
@jdm
Copy link
Member

@jdm jdm commented Nov 4, 2019

The other option is to add a test-tidy invocation to the windows CI as well.

@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Nov 5, 2019

@jdm is llvm 9 installed on the windows CI?

@jdm
Copy link
Member

@jdm jdm commented Nov 5, 2019

All windows builds, local and CI, use the same set of LLVM binaries that are downloaded during the build command by mach. You can check the version in python/servo/packages.py.

@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Nov 22, 2019

Fixed #24692

@paulrouget paulrouget closed this Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.