Hololens click events not working for some people

[Manishearth]

I first thought this was a platform issue, but some folks (including @pcwalton) are having trouble clicking links (etc) on Servo's 2D hololens port.

It might be related to #24547 . I haven't really investigated this since I can't easily replicate it myself, but I think these folks poke instead of tap, and that may trigger mouse events instead of touch events or something.

I think the "tap shadow ripple" which happens when you click on servo is still visible for these folks. (Is that panel.PointerPressed())

The DOM synthesizes events at some point and perhaps our events are in conflict with those.

I might let Patrick use the device with some logging at some point.

cc @paulrouget

[paulrouget]

Might be #24596 - I'll be looking at this this week.

[paulrouget]

I'm not sure how to reproduce.

The UWP port follows these guidelines: https://docs.microsoft.com/en-us/windows/uwp/design/input/handle-pointer-input

Mouse down and up are triggered on released and pressed. Click is triggered on tap.

What is a "poke"? Is it https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.uielement.holding ?

I think the "tap shadow ripple" which happens when you click on servo is still visible for these folk

Can you explain a bit more?

[Manishearth]

By poke I mean that their fingers go through the window instead of briefly making contact.

When you click things in servo you hear a sound and a little shadow appears around the clock, that's the shadow ripple I'm talking about.

[paulrouget]

Would be interesting to see if they miss-click in IE as well.

[paulrouget]

Just poking in IE doesn't not generate, and poking a link doesn't navigate.

So I guess our behavior is consistent with IE at least.

[Yonet]

Click events works on Edge, but not on Servo.
Edge: https://youtu.be/2uv_m_VJMfU
Servo: https://youtu.be/6oYLFx3YwMQ

[Manishearth]

Hmm, this should have been fixed in #25076 cc @paulrouget

[paulrouget]

Back from holidays. I’ll look soon.

[pshaughn]

This is probably unrelated but I want to point it out just in case it is a part of the problem: clicks as currently implemented in Servo aren't doing a good job of bubbling upward, so for instance if you managed to target the text node inside a button with a click you wouldn't necessarily register a click on the button. #25488 is my attempt to fix that sort of thing.

[paulrouget]

Click events works on Edge, but not on Servo.
Edge: https://youtu.be/2uv_m_VJMfU
Servo: https://youtu.be/6oYLFx3YwMQ

Wow, even the mouse move events are not sent.

[paulrouget]

I’m not sure @Yonet issue is directly related to this click issue.

@Yonet do you mind filing another issue for your specific problem (which looks more serious that this specific click issue)? And in that new issue, can you tell me if you can click on the “reload” button in Servo’s toolbar?

[Yonet]

@paulrouget sorry for the late reply. Click works great at the moment. Thanks!