Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build, no clippy #24756

Closed
saschanaz opened this issue Nov 16, 2019 · 4 comments
Closed

Can't build, no clippy #24756

saschanaz opened this issue Nov 16, 2019 · 4 comments
Labels

Comments

@saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Nov 16, 2019

> ./mach build -d --features vslatestinstalled              
**********************************************************************
** Visual Studio 2019 Developer Command Prompt v16.3.2
** Copyright (c) 2019 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x64'
info: syncing channel updates for 'nightly-2019-11-15-x86_64-pc-windows-msvc'
info: latest update on 2019-11-15, rust version 1.41.0-nightly (82cf3a448 2019-11-14)
error: component 'clippy' for target 'x86_64-pc-windows-msvc' is unavailable for download for channel nightly-2019-11-15
Build FAILED in 0:00:00

This happens after #24750. This is why I did 11-05 instead in #24749...

cc @SimonSapin

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Nov 16, 2019

I thought I’d checked https://rust-lang.github.io/rustup-components-history/ yesterday but I must have read it wrong.

But more importantly, why is clippy required? Yes it can be convenient but Servo should still build without it.

@saschanaz
Copy link
Contributor Author

@saschanaz saschanaz commented Nov 16, 2019

It somehow fails immediately if no clippy... Maybe it should be a warning instead.

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Nov 16, 2019

Does rustup install nightly-2019-11-15-x86_64-pc-windows-msvc say the same?

The fact that this is an error rather than a warning is a behavior of rustup (https://github.com/rust-lang/rustup), I don’t know how we can influence it.

@saschanaz
Copy link
Contributor Author

@saschanaz saschanaz commented Nov 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.