Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGStreamer plugin framerates #24833
Closed
GStreamer plugin framerates #24833
Labels
Comments
|
OK, tracking it down, it looks like the plugin is being throttled by the pipeline, but it's running twice per frame. https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/issues/227 |
bors-servo
added a commit
that referenced
this issue
Dec 12, 2019
Block the gstreamer plugin waiting for the next frame <!-- Please describe your changes on the following line: --> Get the GStreamer plugin to produce frames at the requested rate rather than relying on downstream elements to perform throttling. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24833 - [x] These changes do not require tests because <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this issue
Dec 12, 2019
Block the gstreamer plugin waiting for the next frame <!-- Please describe your changes on the following line: --> Get the GStreamer plugin to produce frames at the requested rate rather than relying on downstream elements to perform throttling. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24833 - [x] These changes do not require tests because <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks like the gstreamer plugin is ignoring the negotiated framerate and running at full speed. It shouldn't.