Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure background-hang-monitor exits before constellation #24850

Open
gterzian opened this issue Nov 24, 2019 · 0 comments
Open

Ensure background-hang-monitor exits before constellation #24850

gterzian opened this issue Nov 24, 2019 · 0 comments

Comments

@gterzian
Copy link
Member

@gterzian gterzian commented Nov 24, 2019

code: components/background_hang_monitor.

This component currently runs until script drops it's sender to it, which could be after the constellation exits, so that could add to the "(bad) threads running after exit" count.

Instead, the constellation could share a clone of a IpcSender<()> with each monitor, keep a single IpcReceiver<()>, and as part of exit, receive on it until all senders have dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.