Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build ANGLE binaries with /APPCONTAINER #24892

Closed
jdm opened this issue Nov 27, 2019 · 2 comments
Closed

Build ANGLE binaries with /APPCONTAINER #24892

jdm opened this issue Nov 27, 2019 · 2 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Nov 27, 2019

Right now we fail the AppContainerCheck test in the WACK security features tests.

@jdm jdm added this to To do in UWP port via automation Nov 27, 2019
@jdm jdm moved this from To do to In progress in UWP port Nov 28, 2019
@jdm
Copy link
Member Author

@jdm jdm commented Nov 28, 2019

The following ANGLE patch should address the problem (and will need to be upstreamed):

diff --git a/BUILD.gn b/BUILD.gn
index 036bf68b4..8305603a7 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -1085,7 +1085,11 @@ foreach(is_shared_library,
   }

   target(library_type, library_name) {
-    sources = util_sources
+    if (!angle_is_winuwp) {
+      sources = util_sources
+    } else {
+      sources = []
+    }
     deps = [
       ":angle_common",
       ":angle_util_loader_headers",
@@ -1152,8 +1156,12 @@ foreach(is_shared_library,
     if (is_shared_library) {
       defines = [ "LIBANGLE_UTIL_IMPLEMENTATION" ]

-      if (is_win && !angle_is_winuwp) {
-        sources += util_win_shared_sources
+      if (is_win) {
+        if (angle_is_winuwp) {
+          ldflags = [ "/APPCONTAINER", "/IGNORE:4010" ]
+        } else {
+          sources += util_win_shared_sources
+        }
       }

       public_deps += [ ":angle_util_loader" ]
@jdm jdm added this to In progress in Microsoft app store Dec 10, 2019
@jdm
Copy link
Member Author

@jdm jdm commented Dec 10, 2019

Fixed by #25219.

@jdm jdm closed this Dec 10, 2019
UWP port automation moved this from In progress to Done Dec 10, 2019
@jdm jdm moved this from In progress to Done in Microsoft app store Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
UWP port
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.