Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing whitespace in XHR response headers is exposed #24917

Closed
pshaughn opened this issue Nov 28, 2019 · 0 comments
Closed

Trailing whitespace in XHR response headers is exposed #24917

pshaughn opened this issue Nov 28, 2019 · 0 comments

Comments

@pshaughn
Copy link
Member

@pshaughn pshaughn commented Nov 28, 2019

WPT test xhr/headers-normalize-response asks the server to send back a custom header ending in a space or tab, and unexpectedly can see that trailing space or tab in the returned header. I don't know which code is responsible: this may need a call on whether to strip immediately when storing the headers from the network HTTP response, or to keep the spaces/tabs at that time and strip them when returning them to Javascript getResponseHeader.

Regarding WPT results, Firefox and Safari pass these subtests and fail different subtests which Servo does pass (Servo's doing the right thing on NUL bytes).

@jdm jdm added the A-network label Nov 29, 2019
@jdm jdm added this to To do in web-platform-test failures via automation Nov 29, 2019
Eijebong added a commit to Eijebong/servo that referenced this issue Nov 29, 2019
bors-servo added a commit that referenced this issue Nov 29, 2019
Trim header values in GetResponseHeader

Fixes #24917
bors-servo added a commit that referenced this issue Nov 30, 2019
Trim header values in GetResponseHeader

Fixes #24917
bors-servo added a commit that referenced this issue Dec 2, 2019
Trim header values in GetResponseHeader

Fixes #24917
bors-servo added a commit that referenced this issue Dec 2, 2019
Trim header values in GetResponseHeader

Fixes #24917
@bors-servo bors-servo closed this in a91176e Dec 3, 2019
web-platform-test failures automation moved this from To do to Done Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.