Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPT tests of downloading from an iframe are timing out #24973

Open
pshaughn opened this issue Nov 30, 2019 · 3 comments
Open

WPT tests of downloading from an iframe are timing out #24973

pshaughn opened this issue Nov 30, 2019 · 3 comments

Comments

@pshaughn
Copy link
Member

@pshaughn pshaughn commented Nov 30, 2019

WPT html/semantics/embedded-content/the-iframe-element/iframe_sandbox_anchor_download_allow_downloads.sub.tentative.html and iframe_sandbox_navigation_download_allow_downloads.sub.tentative.html timeout.
In each case an anchor element inside an iframe is being .click()ed and then the test harness expects to be able to tell the download worked.
This could be a problem with clicking anchors in an iframe, or with download mechanisms, or with bad test harness expectations about what Servo does with downloads.

@jdm jdm added this to To do in web-platform-test failures via automation Nov 30, 2019
@pshaughn
Copy link
Member Author

@pshaughn pshaughn commented Dec 23, 2019

These tests are tentative, but the tentative aspect has to do with the sandboxing, not with the fact of downloading from an iframe in the first place. Since Servo isn't currently enforcing sandboxing in general, this timeout might signify something else. Looking at RUST_LOG=net output, the download_stash.py?token= hyperlink doesn't end up sending a request to the network; I'm going to try some more minimal cases to see if there's a real problem here.

@pshaughn
Copy link
Member Author

@pshaughn pshaughn commented Dec 23, 2019

Yes, there is a real problem! #25374 is the real not-related-to-tentative-behavior issue here.

@pshaughn
Copy link
Member Author

@pshaughn pshaughn commented Jan 28, 2020

If the click worked, we'd still probably end up failing this test for lack of any code that tests the "download" attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.