Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement attachInternals and ElementInternals #24988

Open
pshaughn opened this issue Dec 2, 2019 · 5 comments · May be fixed by #25705
Open

Implement attachInternals and ElementInternals #24988

pshaughn opened this issue Dec 2, 2019 · 5 comments · May be fixed by #25705

Comments

@pshaughn
Copy link
Member

@pshaughn pshaughn commented Dec 2, 2019

WPT custom-elements/HTMLElement-attachInternals, custom-elements/ElementInternals-NotSupportedError, custom-elements/form-associated/form-disabled-callback, and all of custom-elements-form-associated/ElementInternals* expect attachInternals to exist, and to return an ElementInternals where appropriate

@jdm jdm added the A-content/dom label Dec 2, 2019
@jdm jdm added this to To do in web-platform-test failures via automation Dec 2, 2019
@pshaughn
Copy link
Member Author

@pshaughn pshaughn commented Feb 6, 2020

I'm going to draft some code toward this, although current WPT status (https://wpt.fyi/results/custom-elements/form-associated?run_id=433960003&run_id=401740001&run_id=439870002&run_id=426710002) suggests Servo shouldn't necessarily go too far out of its way to support form-associated CEs yet.

@pshaughn pshaughn self-assigned this Feb 6, 2020
@pshaughn
Copy link
Member Author

@pshaughn pshaughn commented Feb 8, 2020

Question: does Servo currently have any sense of remembering what was in a form for when you navigate away from a page and come back to it? If so, where's that implemented? It needs to fire a custom element reaction in some cases if it exists at all, and I'm not sure whether it does.

@pshaughn
Copy link
Member Author

@pshaughn pshaughn commented Feb 8, 2020

Now making enough progress that I'm hitting spec/test holes; whatwg/html#5263

@jdm
Copy link
Member

@jdm jdm commented Feb 10, 2020

We only retain form information that is reflected in the current DOM in a page in the bfcache (ie. it hasn't been evicted, so we can activate the pipeline). If the page gets reloaded then all form information is lost.

@pshaughn
Copy link
Member Author

@pshaughn pshaughn commented Feb 15, 2020

In that case one of the callbacks can be defined but has no code ever firing it; the spec only says we have to fire it if we repopulate form data on a return to a page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.