Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customElements.define isn't checking disabledFeatures and formAssociated when expected #25017

Open
pshaughn opened this issue Dec 2, 2019 · 0 comments · May be fixed by #25705
Open

customElements.define isn't checking disabledFeatures and formAssociated when expected #25017

pshaughn opened this issue Dec 2, 2019 · 0 comments · May be fixed by #25705

Comments

@pshaughn
Copy link
Member

@pshaughn pshaughn commented Dec 2, 2019

WPT custom-elements/CustomElementRegistry has various tests that set up call-trace proxies around a custom class and then call customElements.define to see which fields are accessed. In general, disabledFeatures and formAssociated are expected to be accessed but aren't. A quick grep of servo's codebase suggests these strings might not even be in it.

https://html.spec.whatwg.org/multipage/custom-elements.html#custom-elements-api specifies getting them, in substeps 14-6 and 14-12 of the define method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.