Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The object Element.prototype[Symbol.unscopables] itself has a prototype but shouldn't #25022

Open
pshaughn opened this issue Dec 2, 2019 · 1 comment

Comments

@pshaughn
Copy link
Member

@pshaughn pshaughn commented Dec 2, 2019

WPT WebIDL/emcascript-binding/interface-prototype-object.html tests this and fails; other browsers pass.

@jdm jdm added this to To do in web-platform-test failures via automation Dec 2, 2019
@pshaughn
Copy link
Member Author

@pshaughn pshaughn commented Dec 23, 2019

https://heycam.github.io/webidl/#interface-prototype-object 8.1 tells us to create this object with a null prototype. interface.rs create_unscopable_object calls JS_NewPlainObject, which is the wrong constructor: it's creating a "plain" object in the sense that {} is a plain object, having the default Object.prototype rather than the unusual special case of a completely absent prototype. I'll see if JS_NewObject(*cx, ptr::null()), as seen in create_callback_interface_object, has the desired result.

Update: No, it did not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.