Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent failure with TypeError: Network error occurred #25027

Open
Manishearth opened this issue Dec 3, 2019 · 3 comments
Open

Intermittent failure with TypeError: Network error occurred #25027

Manishearth opened this issue Dec 3, 2019 · 3 comments

Comments

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Dec 3, 2019

This happened with /html/dom/idlharness.https.html?exclude=(Document|Window|HTML.*) but I strongly suspect it's not about that specific test.

  ▶ Unexpected subtest result in /html/dom/idlharness.https.html?exclude=(Document|Window|HTML.*):
  │ FAIL [expected PASS] idl_test setup
  └   → promise_test: Unhandled rejection with value: object "TypeError: Network error occurred"
@Manishearth
Copy link
Member Author

@Manishearth Manishearth commented Dec 3, 2019

The relevant error comes from fetch:

promise.reject_error(Error::Type("Network error occurred".to_string()));

(should that be an Error::Network?)

@pshaughn
Copy link
Member

@pshaughn pshaughn commented Dec 7, 2019

Most of the times I've seen this error in WPT tests, it's been a response header that Servo interpreted as CORS-disallowed or otherwise unacceptable. And unfortunately it IS supposed to be a TypeError! https://fetch.spec.whatwg.org/ specifies TypeError in many situations that are not really type-related.

@jdm jdm mentioned this issue Dec 9, 2019
4 of 4 tasks complete
@jdm
Copy link
Member

@jdm jdm commented Dec 25, 2019

I have observed this problem in 7474b30, but it appears to have become much more frequent between 3996326 and d657a6c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.