Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two gstreamer plugins, both called servosrc #25051

Closed
asajeffrey opened this issue Dec 3, 2019 · 1 comment
Closed

Two gstreamer plugins, both called servosrc #25051

asajeffrey opened this issue Dec 3, 2019 · 1 comment
Labels
A-content/media P-gst-plugin

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Dec 3, 2019

Servo media has a plugin called ServoSrc which conflicts with the one in ports/gstplugin. https://github.com/servo/media/blob/1e527446cf57f5a8773cda1257e46957a295dd9c/backends/gstreamer/source.rs#L247-L249
@asajeffrey asajeffrey mentioned this issue Dec 9, 2019
Merged
4 of 4 tasks complete
@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Dec 10, 2019

Sigh, #25218 fixed the type name clash (which caused a panic) but not the plugin name clash (which causes the wrong plugin to get loaded). We need to rename servosrc which is a pity as that's the user-visible name.
@asajeffrey asajeffrey reopened this Dec 10, 2019
@asajeffrey asajeffrey mentioned this issue Dec 11, 2019
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Dec 11, 2019
@bors-servo
Auto merge of #25243 - asajeffrey:gstplugin-name-unclash-no-really-i-…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5d40986 
…mean-it-this-time, r=Manishearth

Rename servosrc to servowebsrc

<!-- Please describe your changes on the following line: -->

Really fixes a name clash with servo-media. Really.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25051
- [x] These changes do not require tests because

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/media P-gst-plugin
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Rename the ServoSrc type to ServoGstSrc to avoid a name clash
Rename servosrc to servowebsrc
1 participant
@asajeffrey
You can’t perform that action at this time.