Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to start the devtools after startup #25119

Open
paulrouget opened this issue Dec 5, 2019 · 3 comments
Open

Make it possible to start the devtools after startup #25119

paulrouget opened this issue Dec 5, 2019 · 3 comments

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Dec 5, 2019

No description provided.

@highfive
Copy link

@highfive highfive commented Dec 5, 2019

@jdm
Copy link
Member

@jdm jdm commented Dec 5, 2019

This has interesting implications, because every script thread has a direct channel to the devtools server, and is responsible for sending notifications about new globals. One possibility is that we could have the channels always exist and slowly fill up over time with nothing reading them; this would allow us to start the devtools server later and read the backlog of messages to end up in a reasonable state.

The other option would be to have script threads store an optional channel, and when it's time to start a server then the constellation distributes a channel to all script threads, who then send notifications about the globals that currently exist. We might need to add some kind of buffering somewhere for console.log output/JS exceptions/etc. that could be sent when connecting to a global, as well, so that developers are able to see output that occurred before the devtools server started?

@jdm
Copy link
Member

@jdm jdm commented Dec 5, 2019

We might be able to make it easier by having the script thread always talk to the constellation instead of directly to the devtools, which can then make decisions about buffering or discarding in a single central location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.