Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GStreamer plugin wrong memory type #25121

Closed
asajeffrey opened this issue Dec 5, 2019 · 2 comments
Closed

GStreamer plugin wrong memory type #25121

asajeffrey opened this issue Dec 5, 2019 · 2 comments
Labels
P-gst-plugin

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Dec 5, 2019

With #25048, the plugin sometimes fails due to receiving regular memory rather than GL memory to fill. This is caused by the plugin not setting up a buffer pool (which in GStreamer is the source's responsibility, not the sink's).
@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Dec 5, 2019

https://gstreamer.freedesktop.org/documentation/additional/design/bufferpool.html?gi-language=c#negotiation
@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Dec 5, 2019

The fix in my gstreamer plugin playground is asajeffrey/my-gst-plugin@14f6657
@asajeffrey asajeffrey mentioned this issue Dec 5, 2019
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Dec 9, 2019
@bors-servo
Auto merge of #25139 - asajeffrey:gstplugin-glmemory-bufferpool, r=Ma…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
530a2d1 
…nishearth

Use a glmemory bufferpool

<!-- Please describe your changes on the following line: -->

This ensures the gstreamer plugin is always using GLMemory.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25121
- [x] These changes do not require tests because

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo bors-servo closed this in daf7138 Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-gst-plugin
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Use a glmemory bufferpool
1 participant
@asajeffrey
You can’t perform that action at this time.