Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing-to-reproduce crash in WPT dom/nodes/ParentNode-querySelector-All-xht.xht #25123

Closed
pshaughn opened this issue Dec 5, 2019 · 5 comments
Closed
Labels

Comments

@pshaughn
Copy link
Member

@pshaughn pshaughn commented Dec 5, 2019

The crash is happening on either foundall = root.querySelectorAll(q); or assert_not_equals(foundall, null, "The method should not return null.") during runValidSelectorTest("Document", doc, validSelectors, testType, docType); It happens most of the time when I am running headless.

The confusing thing is that if I change the loop for(var i=0; i < selectors.length; i++) to only go over the first half of selectors, or only the second half, the test doesn't crash. The crash only happens when I'm using lots and lots of query selectors in a row, not reliably for any individual one, suggesting perhaps some unsafe operation is slightly wrong in a way that can add up to a memory problem.

I get no stacktrace.

@jdm
Copy link
Member

@jdm jdm commented Dec 5, 2019

Any difference if you run the test inside a debugger with --debugger?

@jdm jdm added the I-crash label Dec 5, 2019
@pshaughn
Copy link
Member Author

@pshaughn pshaughn commented Dec 5, 2019

Answered in IRC, repeating here to keep it visible: It doesn't crash when I do that.

@jdm
Copy link
Member

@jdm jdm commented Dec 5, 2019

I wonder if you're hitting a long-enough running script in a debug build that the hang detector kicks in, then tries to capture a backtrace and segfaults inside libbacktrace :<

@pshaughn
Copy link
Member Author

@pshaughn pshaughn commented Dec 12, 2019

Probably #24984; I'll retest to make sure.

@pshaughn
Copy link
Member Author

@pshaughn pshaughn commented Dec 12, 2019

No longer reproducing.

@pshaughn pshaughn closed this Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.