Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up_charset_ hidden field isn't working in WPT html/semantics/forms/form-submission-0/constructing-form-data-set.html #25151
Comments
|
Possibly this is a timing issue in which the target frame's location hasn't updated to include the form GET when we look at it. on second look, no, it's an onload, the location has to have changed by now. |
|
@highfive assign me |
|
Hey @pshaughn! Thanks for your interest in working on this issue. It's now assigned to you! |
|
My earlier guess about the target frame's location wasn't as wrong as I thought it was. |
|
This differs from #25154 in that the unwanted load is happening here even though the frame's src is never explicitly set. |
|
3b9ab34#diff-01b44abc6218a3ab6d34cd50e43440fd shows that something like this has happened before; I'll try copying that workaround! update: the workaround works to move the test forward, I am now testing the correct onload (which does indeed contain the wrong value) |
|
The right thing happens if I don't touch the Rust code at all; it's happening in the wrong place relative to WHATWG specs, but it's passing the fixed test. |
Workarounds for form-submission-0 tests with about:blank onloads <!-- Please describe your changes on the following line: --> Following the model of 3b9ab34 these changes replace some naive onload events with equivalents that do nothing if they see an about:blank load event. Two test cases now pass, and one failing test case is now failing for a less ambiguous reason (#25154) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25151 and fix #25152. <!-- Either: --> - [X] These changes do not require tests because these are fixes to tests only, not code changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
script/dom/htmlformelement.rs does have special-case code for charset as required by https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#naming-form-controls:-the-name-attribute but in this test it isn't working for some reason.