Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

location.search is unexpectedly empty in WPT html/semantics/forms/form-submission-0/form-submission-algorithm.html #25152

Closed
pshaughn opened this issue Dec 6, 2019 · 2 comments
Closed

location.search is unexpectedly empty in WPT html/semantics/forms/form-submission-0/form-submission-algorithm.html #25152

pshaughn opened this issue Dec 6, 2019 · 2 comments
Labels
A-content/dom C-assigned
Projects
web-platform-test failures

Comments

@pshaughn
Copy link
Member

@pshaughn pshaughn commented Dec 6, 2019

This is the check for 'n=i' in the "If form's firing submission events is true, then return; 'submit' event" case. Possibly name/value pairs on type=submit inputs are being ignored.
@jdm jdm added the A-content/dom label Dec 6, 2019
@jdm jdm added this to To do in web-platform-test failures via automation Dec 6, 2019
@pshaughn
Copy link
Member Author

@pshaughn pshaughn commented Dec 9, 2019

@highfive assign me
This is probably a test expectation about about:blank behavior as seen in whatwg/html#490 and if it isn't I've been diving around in the right part of the code tree for it anyway.
@highfive highfive added the C-assigned label Dec 9, 2019
@highfive
Copy link

@highfive highfive commented Dec 9, 2019

Hey @pshaughn! Thanks for your interest in working on this issue. It's now assigned to you!
@pshaughn pshaughn mentioned this issue Dec 9, 2019
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Dec 10, 2019
@bors-servo
Auto merge of #25220 - pshaughn:patch25151, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
11a30f1 
Workarounds for form-submission-0 tests with about:blank onloads

<!-- Please describe your changes on the following line: -->
Following the model of 3b9ab34 these changes replace some naive onload events with equivalents that do nothing if they see an about:blank load event. Two test cases now pass, and one failing test case is now failing for a less ambiguous reason (#25154)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25151 and fix #25152.

<!-- Either: -->
- [X] These changes do not require tests because these are fixes to tests only, not code changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
web-platform-test failures automation moved this from To do to Done Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom C-assigned
Projects
web-platform-test failures
  
Done
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Workarounds for form-submission-0 tests with about:blank onloads
3 participants
@jdm @pshaughn @highfive
You can’t perform that action at this time.