Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement auxclick events #25181

Open
pshaughn opened this issue Dec 6, 2019 · 3 comments
Open

Implement auxclick events #25181

pshaughn opened this issue Dec 6, 2019 · 3 comments

Comments

@pshaughn
Copy link
Member

@pshaughn pshaughn commented Dec 6, 2019

I encountered this because various tests under WPT html/webappapis/scripting want to try every single global event handler to see if on* is connected to addEventListener(*) in the appropriate way; this is one of four missing ones.

Auxclick is just like click, but for buttons that aren't the primary one. https://w3c.github.io/uievents/#event-type-auxclick

@pshaughn
Copy link
Member Author

@pshaughn pshaughn commented Dec 23, 2019

This needs port-specific code changes to make sure UI clicks are actually sent for non-primary buttons. ports/glutin currently has a special case for just

MouseWindowEvent::Click(MouseButton::Left, coords.to_f32())
and doesn't send MouseWindowEvent::Click for other buttons.

@chotchki
Copy link
Contributor

@chotchki chotchki commented Jul 29, 2020

So looking at the code here:

MouseWindowEvent::MouseDown(MouseButton::Left, coords.to_f32())

It looks like it gets either left or right buttons and just emits left only. Would more buttons matter like a middle mouse button?

@jdm
Copy link
Member

@jdm jdm commented Jul 29, 2020

Yes, we would want to capture any mouse button input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.