Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement onformdata as an event handler IDL attribute #25183
Comments
|
I think only need to add Code: servo/components/script/dom/webidls/EventHandler.webidl Lines 27 to 29 in 2d2cd2b Test: |
|
Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the If you intend to work on this issue, then add |
|
I would like to try this! |
|
Hey @xu3u4! Thanks for your interest in working on this issue. It's now assigned to you! |
…dler, r=<try> Add onformdata to GlobalEventHandlers <!-- Please describe your changes on the following line: --> 1. Adding `onformdata` to GlobalEventHandlers interface and global_event_handlers macro. 2. Deleting related FAIL tests. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25183 (GitHub issue number if applicable) <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
…dler, r=jdm Add onformdata to GlobalEventHandlers <!-- Please describe your changes on the following line: --> 1. Adding `onformdata` to GlobalEventHandlers interface and global_event_handlers macro. 2. Deleting related FAIL tests. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25183 (GitHub issue number if applicable) <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
…dler, r=jdm Add onformdata to GlobalEventHandlers <!-- Please describe your changes on the following line: --> 1. Adding `onformdata` to GlobalEventHandlers interface and global_event_handlers macro. 2. Deleting related FAIL tests. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25183 (GitHub issue number if applicable) <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
https://html.spec.whatwg.org/multipage/webappapis.html#event-handlers-on-elements,-document-objects,-and-window-objects lists onformdata. FormDataEvent already exists thanks to @CYBAI in #22660; it just needs its matching on* attribute.