Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove obsolete special-case handling of Boolean return value from mouseover event #25190
Labels
Projects
Comments
pshaughn
changed the title
|
@highfive assign me |
|
Hey @pshaughn! Thanks for your interest in working on this issue. It's now assigned to you! |
bors-servo
added a commit
that referenced
this issue
Dec 11, 2019
Took out the special mouseover cancel case <!-- Please describe your changes on the following line: --> eventtarget.rs was checking the event type to see if it was a mouseover; now it doesn't. Other special-case events like error and beforeunload go down other code paths entirely, so this one has no special cases left. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25190 <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
WPT html/webappapis/scripting/events/event-handler-processing-algorithm.html handily points us at whatwg/html#2398 which removed a Gecko-specific quirk from the spec and came with a matching WPT change. Mouseover events should now just do the same thing on true/false as other mouse events.