Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix mach bootstrap on Windows #25224
Open
Comments
|
According to https://github.com/servo/servo/blob/master/python/servo/command_base.py#L316 |
|
This might be a regression from #24567. |
MeFisto94
added a commit
to MeFisto94/servo
that referenced
this issue
Dec 12, 2019
… bootstrap can successfully download dependencies to it
MeFisto94
added a commit
to MeFisto94/servo
that referenced
this issue
Dec 12, 2019
… bootstrap can successfully download dependencies to it
MeFisto94
added a commit
to MeFisto94/servo
that referenced
this issue
Dec 12, 2019
… bootstrap can successfully download dependencies to it
MeFisto94
added a commit
to MeFisto94/servo
that referenced
this issue
Dec 12, 2019
… bootstrap can successfully download dependencies to it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to jdm on the IRC, mach bootstrap doesn't do anything useful, because every build-related command is already triggering windows_msvc.
Invoking bootstrap however, is done by https://github.com/servo/servo/blob/master/python/servo/bootstrap.py#L396 which in turn is called from https://github.com/servo/servo/blob/master/python/mach_bootstrap.py#L241
The following exception happens when ./mach bootstrap is invoked:
I think the solution to this is adding
context.sharedir = os.path.join(context.topdir, ".servo")to the lastly linked code in mach_bootstrap.py, because other build tasks indeed do download the dependencies to.servorelative to the topdir.Note that this would affect windows and linux alike, but it seems this sharedir is only requested from salt and windows and not linux, which installs the packets globally using apt.