Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python error when reporting non-intermittent failures on mac #25233

Open
jdm opened this issue Dec 10, 2019 · 1 comment
Open

Python error when reporting non-intermittent failures on mac #25233

jdm opened this issue Dec 10, 2019 · 1 comment
Labels

Comments

@jdm
Copy link
Member

@jdm jdm commented Dec 10, 2019

From https://community-tc.services.mozilla.com/tasks/B5l6bUP7Rsqe2TNtsAkKSQ/runs/0/logs/https%3A%2F%2Fcommunity-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2FB5l6bUP7Rsqe2TNtsAkKSQ%2Fruns%2F0%2Fartifacts%2Fpublic%2Flogs%2Flive.log

+ ./mach filter-intermittents wpt-jsonsummary.log --log-intermittents intermittents.log --log-filteredsummary filtered-wpt-errorsummary.log --tracker-api default --reporter-api default
Error running mach:
    ['filter-intermittents', 'wpt-jsonsummary.log', '--log-intermittents', 'intermittents.log', '--log-filteredsummary', 'filtered-wpt-errorsummary.log', '--tracker-api', 'default', '--reporter-api', 'default']
The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You should consider filing a bug for this issue.
If filing a bug, please include the full output of mach, including this error
message.
The details of the failure are as follows:
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 57: ordinal not in range(128)
  File "/Users/worker/tasks/task_1575999096/repo/python/servo/testing_commands.py", line 580, in filter_intermittents
    format(actual_failures, description)
  File "/Users/worker/tasks/task_1575999096/repo/python/servo/testing_commands.py", line 568, in format
    file.write(formatted.encode("utf-8"))
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 357, in write
    data, consumed = self.encode(object, self.errors)

cc @SimonSapin

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Dec 11, 2019

Like before, the filtered-wpt-errorsummary.log artifacts contain the same information that the failing code would print. So we can look there until this is fixed.

@mrobinson mrobinson mentioned this issue Feb 11, 2020
3 of 5 tasks complete
luka-zitnik added a commit to luka-zitnik/servo that referenced this issue Feb 18, 2020
@luka-zitnik luka-zitnik mentioned this issue Feb 18, 2020
4 of 5 tasks complete
bors-servo added a commit that referenced this issue Apr 1, 2020
Prevent double encoding

Fixes #25233

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25233 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because testing_commands.py has no tests.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue Apr 1, 2020
Prevent double encoding

Fixes #25233

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25233 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because testing_commands.py has no tests.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.