Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BabylonJS demo: looks like we are below the floor #25318

Closed
paulrouget opened this issue Dec 17, 2019 · 3 comments
Closed

BabylonJS demo: looks like we are below the floor #25318

paulrouget opened this issue Dec 17, 2019 · 3 comments
Labels
A-webcompat A-xr-zomg

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Dec 17, 2019

https://servo.org/hl-home/bbjs/#JA1ND3%23163

The camera is below the floor. The demo hasn’t changed in a while. Likely a servo regression.
@jdm
Copy link
Member

@jdm jdm commented Dec 17, 2019

@Manishearth Could this be #25025?
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Dec 17, 2019

No, I knew this would happen but was going to fix it so didn't file. This is #25259 which made us use the floor level defined in openxr/mod.rs, which is 1 meter instead of two. The quick fix is to make it 2. I want to land the actual fix for that soon.
@jdm
Copy link
Member

@jdm jdm commented Jul 14, 2020

This doesn't happen any more.
@jdm jdm closed this Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-webcompat A-xr-zomg
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@jdm @paulrouget @Manishearth
You can’t perform that action at this time.