Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPossible security issue when deleting databases for IndexedDB #25320
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When handeling the
SyncOperation::DeleteDatabasecase inhandle_sync_operationwe sanitize the name through anIndexedDBDescriptionand runstd::fs::remove_dir_all(...)with this name.If
std::fs::remove_dir_allgets the wrong input, things can go very badly and start to delete the wrong files instead of the database files.We should evaluate if this is a true security issue, or if the string sanitation covers all malicious input.
function:
handle_sync_operationfiles:
components\net\indexeddb\idb_thread.rs