Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unwrap/expect when sending messages for IndexedDB #25321

Open
rasviitanen opened this issue Dec 17, 2019 · 0 comments
Open

Replace unwrap/expect when sending messages for IndexedDB #25321

rasviitanen opened this issue Dec 17, 2019 · 0 comments

Comments

@rasviitanen
Copy link
Contributor

@rasviitanen rasviitanen commented Dec 17, 2019

Failing to send a message to the thread that starts a SyncOperation should not take down the whole idb thread, instead we should just fire some warnings using warn!.

To clarify

Change:
sender.send(result).unwrap() or sender.send(result).expect(...);

to something like this:

if sender.send(result).is_err() {
    warn!("Some Message");
}

Files:
components\net\indexeddb\idb_thread.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.