Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting a Value to a Key for IndexedDB is missing some cases #25327

Open
rasviitanen opened this issue Dec 18, 2019 · 0 comments
Open

Converting a Value to a Key for IndexedDB is missing some cases #25327

rasviitanen opened this issue Dec 18, 2019 · 0 comments

Comments

@rasviitanen
Copy link
Contributor

@rasviitanen rasviitanen commented Dec 18, 2019

Converting a Value to a Key does not behave as we expect and the implementation is incomplete. For example, we are not able to convert Arrays and Dates. This will also require some changes to the IndexedDBKeyType located in compontents/net_traits/indexeddb_thread.rs, as we need to add support for Arrays and Dates as keys.

Task

  • Complete the implementation

Function
convert_value_to_key

Files
components/script/dom/idbobjectstore.rs
compontents/net_traits/indexeddb_thread.rs

Specification
https://www.w3.org/TR/IndexedDB-2/#convert-value-to-key

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.