Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Packaging DLLs fails when WindowsSdkDir isn't set #25360

Closed
MeFisto94 opened this issue Dec 22, 2019 · 0 comments
Closed

Windows: Packaging DLLs fails when WindowsSdkDir isn't set #25360

MeFisto94 opened this issue Dec 22, 2019 · 0 comments
Labels
P-windows

Comments

@MeFisto94
Copy link
Contributor

@MeFisto94 MeFisto94 commented Dec 22, 2019 •
edited

This is related to #25336: Without vcvars.bat WindowsSdkDir=C:\Program Files (x86)\Windows Kits\10\ isn't set for me.

This is the case because locating my VS Path fails and thus vcvarsall.bat wasn't found. Also I'm not launching mach.bat at all but the unix version from Mozilla-Build Environment.

To me there are two solutions here:

I'll look into the second approach as that looks like the best (as in most stable and clean) solution to me, even though this specific issue would be easier to solve by looking at the registry.

Edit: Also maybe https://github.com/servo/servo/blob/master/python/servo/build_commands.py#L1003 should be at least a warning?

Edit2: editbin (build_commands.py:681) also requires vcvars, so the second option will be the way to go, without doubt.
@MeFisto94 MeFisto94 mentioned this issue Dec 22, 2019
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Dec 23, 2019
@bors-servo
Auto merge of #25365 - MeFisto94:autolaunch-vcvars, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3c2deaf 
Launch vcvarsall.bat for the recognized VS Installation Directory from python instead of making mach.bat try that on hardcoded paths.

Move the Execution of vcvars (which sets up the environment for visual studio tools) from mach.bat to python, so that ./mach works under mozilla-build and that #25300 can be used.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25360 #25336
- [X] These changes do not require tests because changes to build infra
@CYBAI CYBAI added the P-windows label Dec 23, 2019
bors-servo added a commit that referenced this issue Jan 9, 2020
@bors-servo
Auto merge of #25365 - MeFisto94:autolaunch-vcvars, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5c3b061 
Launch vcvarsall.bat for the recognized VS Installation Directory from python instead of making mach.bat try that on hardcoded paths.

Move the Execution of vcvars (which sets up the environment for visual studio tools) from mach.bat to python, so that ./mach works under mozilla-build and that #25300 can be used.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25360 #25336
- [X] These changes do not require tests because changes to build infra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-windows
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Launch vcvarsall.bat for the recognized VS Installation Directory from python instead of making mach.bat try that on hardcoded paths.
2 participants
@CYBAI @MeFisto94
You can’t perform that action at this time.