Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location is missing some exotic behaviors #25378

Open
pshaughn opened this issue Dec 24, 2019 · 1 comment
Open

Location is missing some exotic behaviors #25378

pshaughn opened this issue Dec 24, 2019 · 1 comment

Comments

@pshaughn
Copy link
Member

@pshaughn pshaughn commented Dec 24, 2019

WPT html/browsers/history/the-location-interface/ has various tests that the Location exotic object does things in its own way, as https://html.spec.whatwg.org/multipage/history.html#the-location-interface warns us it must. Some of these tests fail, such as the ones that try to set its prototype. I don't know how much of this is codegen's responsibility and how much is Location::new_inherited's responsibility.

@pshaughn
Copy link
Member Author

@pshaughn pshaughn commented Dec 24, 2019

/// This implementation always handles the case of the ordinary
/// `[[GetPrototypeOf]]` behavior. An alternative implementation will be
/// necessary for the Location object.
pub unsafe extern "C" fn get_prototype_if_ordinary(

WindowProxy has a special different get_prototype_if_ordinary to itself; Location must need one too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.