Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "Option" named constructor for HTMLOptionElement #25380

Closed
pshaughn opened this issue Dec 24, 2019 · 2 comments
Closed

Implement "Option" named constructor for HTMLOptionElement #25380

pshaughn opened this issue Dec 24, 2019 · 2 comments

Comments

@pshaughn
Copy link
Member

@pshaughn pshaughn commented Dec 24, 2019

A constructor named Option is specified in https://html.spec.whatwg.org/#dom-option, expected in passing by various WPT tests, and specifically tested in html/semantics/forms/the-option-element/option-element-constructor.html. Servo has it commented out in HTMLOptionElement.webidl.

@jdm jdm added this to To do in web-platform-test failures via automation Dec 24, 2019
@jdm jdm added the A-content/dom label Dec 24, 2019
@teapotd
Copy link
Contributor

@teapotd teapotd commented Dec 25, 2019

@highfive assign me

@highfive
Copy link

@highfive highfive commented Dec 25, 2019

Hey @teapotd! Thanks for your interest in working on this issue. It's now assigned to you!

@highfive highfive added the C-assigned label Dec 25, 2019
@teapotd teapotd mentioned this issue Dec 26, 2019
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Jan 3, 2020
Implement HTMLOptionElement named constructor

This change implements `Option` named constructor for `HTMLOptionElement`.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25380
- [X] There are tests for these changes
bors-servo added a commit that referenced this issue Jan 3, 2020
Implement HTMLOptionElement named constructor

This change implements `Option` named constructor for `HTMLOptionElement`.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25380
- [X] There are tests for these changes
bors-servo added a commit that referenced this issue Jan 3, 2020
Implement HTMLOptionElement named constructor

This change implements `Option` named constructor for `HTMLOptionElement`.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25380
- [X] There are tests for these changes
bors-servo added a commit that referenced this issue Jan 3, 2020
Implement HTMLOptionElement named constructor

This change implements `Option` named constructor for `HTMLOptionElement`.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25380
- [X] There are tests for these changes
@bors-servo bors-servo closed this in 77db7ea Jan 3, 2020
web-platform-test failures automation moved this from To do to Done Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.