Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use create_html_element in Audio and Image constructors #25421

Closed
jdm opened this issue Jan 3, 2020 · 3 comments
Closed

Use create_html_element in Audio and Image constructors #25421

jdm opened this issue Jan 3, 2020 · 3 comments
Labels
A-content/dom C-assigned C-has open PR E-easy

Comments

@jdm
Copy link
Member

@jdm jdm commented Jan 3, 2020

#25393 (comment)
@highfive
Copy link

@highfive highfive commented Jan 3, 2020

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄
@warren-fisher
Copy link
Contributor

@warren-fisher warren-fisher commented Jan 4, 2020

@highfive: assign me
@highfive highfive added the C-assigned label Jan 4, 2020
@highfive
Copy link

@highfive highfive commented Jan 4, 2020

Hey @warren-fisher! Thanks for your interest in working on this issue. It's now assigned to you!
@warren-fisher warren-fisher mentioned this issue Jan 4, 2020
Merged
4 of 5 tasks complete
@jdm jdm added the C-has open PR label Jan 21, 2020
bors-servo added a commit that referenced this issue Jan 21, 2020
@bors-servo
Auto merge of #25431 - warren-fisher:create-html-element, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d099e70 
use create_html_element for HTMLAudioElement and HTMLImageElement

<!-- Please describe your changes on the following line: -->

Updated the Image and Audio constructors to use `create_html_element` via the Element::create method. This was done to meet these specifications of "Let (audio/image) be the result of **creating an element** given document, audio, and the HTML namespace." for [dom-image](https://html.spec.whatwg.org/multipage/embedded-content.html#dom-image) and [dom-audio](https://html.spec.whatwg.org/multipage/media.html#dom-audio)
Not sure what _is_ is according to the [create-element guidelines](https://dom.spec.whatwg.org/#concept-create-element) so I left it as None copying from #25393. Also copied the ElementCreator and CustomElementCreationMode from #25393 as I do not know what they do.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25421 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because it is a small swap out of the way used to generate these HTML elements. The pre-existing tests should be sufficient.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom C-assigned C-has open PR E-easy
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

use create_html_element for HTMLAudioElement and HTMLImageElement
3 participants
@jdm @highfive @warren-fisher
You can’t perform that action at this time.